fix: use return instead of raise StopIteration in QuerySet.__iter__#1788
Open
jacalata wants to merge 1 commit into
Open
fix: use return instead of raise StopIteration in QuerySet.__iter__#1788jacalata wants to merge 1 commit into
jacalata wants to merge 1 commit into
Conversation
jacalata
force-pushed
the
jac/fix-stop-iteration
branch
2 times, most recently
from
41e1b2c to
8902534
Compare
Per PEP 479, StopIteration raised inside a generator is converted to RuntimeError. QuerySet.__iter__ is a generator and was raising StopIteration to handle 400006 (invalid page number) errors, causing RuntimeError for callers iterating endpoints that don't support pagination past the last page. Fixes #1786 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jacalata
force-pushed
the
jac/fix-stop-iteration
branch
from
8902534 to
922d20f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per PEP 479,
StopIterationraised inside a generator is converted toRuntimeError.QuerySet.__iter__is a generator and was raisingStopIterationto handle 400006 (invalid page number) errors, which would causeRuntimeErrorfor callers iterating endpoints that don't reporttotalAvailable(e.g.flow_runs).The fix is a one-line change:
returninstead ofraise StopIteration.Fixes #1786
Test plan
test/test_pager.py🤖 Generated with Claude Code